Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add Nitro hooks types declarations #2655

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix: add Nitro hooks types declarations #2655

merged 1 commit into from
Jun 7, 2024

Conversation

Coiggahou2002
Copy link
Contributor

🔗 Linked issue

#2177

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #2177 by augmenting the NitroRuntimeHook typing to provide typings of hook content:beforeParse and content:afterParse (and also IDE intellisense of course)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

farnabaz
farnabaz approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@farnabaz farnabaz merged commit ac66984 into nuxt:main Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farnabaz farnabaz farnabaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Nitro hooks types declarations
2 participants
@Coiggahou2002 @farnabaz