-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: start storybook in same process as dev server #592
Conversation
👷 Deploy request for nuxt-storybook pending review.Visit the deploys page to approve it
|
This looks awesome! and essential for me to continue using the plugin 😄 |
Super excited to see this work. Is there something blocking this that needs help resolving? Looking to find somewhere to contribute if I can. |
@mehcode Thanks for the offer. In it's current state of this PR, if you run |
I'll take a look. |
@tobiasdiez When I run this branch (after rebasing to
|
The The other error goes away if you uncomment the preview proxies. |
Thanks a lot for having a look. It is indeed working now (very rarely I still got an "iframe" not found error in the console but everything seemed to work fine...so who cares ;-) ) |
Today I updated storybook and nuxt storybook, could this change be related?
|
Can be tracked here |
Instead of invoking the storybook cli, we now start the storybook dev server in the same process as the nuxt dev server.
This has the advantage that we don't need to spawn a second nuxt instance, improving preformance and reducing complexifty.
Fixes storybook-vue/storybook-nuxt#59 and fixes #610 and fixes #635 and fixes #475.