test: replace impl-detail assertions with behavioral ones#267
Merged
Conversation
commit: |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
better-auth | dba0446 | Mar 19 2026, 06:18 AM |
onmax
force-pushed
the
test/behavioral-assertions
branch
from
e0d1b31 to
b1c901c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toHaveBeenCalledWith,toHaveBeenCalledOnce,toHaveBeenCalledTimes) where state/output assertions already prove behaviorvi.mock('h3')with realcreateErrorin session teststoEqual→toBe(reference equality proves caching without mock call counts)toHaveBeenCalledBeforewith behavioral assertion (capture session state inside onSuccess callback)mockClient.useSession.toHaveBeenCalledOnce()withauth.client/auth.readystate checksTest plan