Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "BACKPORT-Resolve test case random failure" #2370

Open
wants to merge 1 commit into
base: maintenance-3.0.x
Choose a base branch
from
+8 −16
Open

Revert "BACKPORT-Resolve test case random failure" #2370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ftest/features/publication.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,4 +156,4 @@ Feature: Internal Publication
Then I can see the document is a publication
And I cannot see to publication pill
And I can unpublish the document
And I can see the document has 2 children
And I can see the document has 2 children
9 changes: 3 additions & 6 deletions packages/nuxeo-web-ui-ftest/features/step_definitions/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,14 +199,11 @@ Then('I edit the results columns to show {string}', async function(heading) {
});

Then(/^I save my search as "(.+)"$/, async function(searchName) {
const searchResults = await this.ui.searchResults;
const saveAsButton = await searchResults.saveSearchAsButton;
const saveAsButton = await this.ui.searchResults.saveSearchAsButton;
await saveAsButton.waitForVisible();
await saveAsButton.click();
await driver.pause(2000);
await searchResults.enterInput(searchName);
await driver.pause(2000);
const confirmSaveButton = await searchResults.confirmSaveSearchButton;
await this.ui.searchResults.enterInput(searchName);
const confirmSaveButton = await this.ui.searchResults.confirmSaveSearchButton;
await confirmSaveButton.click();
});

Expand Down
2 changes: 0 additions & 2 deletions packages/nuxeo-web-ui-ftest/pages/ui/admin/cloudServices.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,6 @@ export default class CloudServices extends BasePage {
}

async deleteClient(clientId) {
const dataTable = await driver.$('nuxeo-data-table nuxeo-data-table-row [name="id"]');
await dataTable.waitForVisible();
const rows = await browser.$$('nuxeo-data-table[name="table"] nuxeo-data-table-row:not([header])');
const deleted = await browser
.$$('nuxeo-data-table[name="table"] nuxeo-data-table-row:not([header])')
Expand Down
3 changes: 1 addition & 2 deletions packages/nuxeo-web-ui-ftest/pages/ui/browser/document_publications.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ export default class DocumentPublications extends BasePage {
let index;
for (let i = 0; i < rows.length; i++) {
const row = rows[i];
const isRowVisible = await row.isVisible('nuxeo-data-table-cell a.path');
if (isRowVisible) {
if (row.isVisible('nuxeo-data-table-cell a.path')) {
const foundPathEle = await row.$('nuxeo-data-table-cell a.path');
const foundPath = await foundPathEle.getText();
const foundPathLowerCase = await foundPath.trim().toLowerCase();
Expand Down
3 changes: 1 addition & 2 deletions packages/nuxeo-web-ui-ftest/pages/ui/browser/document_versions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ export default class DocumentVersions extends BasePage {
return true;
}
const listItems = await this.listItems;
const versionItem = await listItems.$('div[name="version-item"] .title');
await versionItem.waitForVisible();
await listItems.$('div[name="version-item"] .title').waitForVisible();
const listItems1 = await this.listItems.$$('div[name="version-item"]');
const itemsTitle = await browser.$$('div[name="version-item"]').map((img) => img.$('.title').getText());
const index = itemsTitle.findIndex((currenTitle) => currenTitle === label);
Expand Down
5 changes: 2 additions & 3 deletions packages/nuxeo-web-ui-ftest/pages/ui/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,8 @@ export default class Search extends Results {
return dropdownElenent;
}

async enterInput(text) {
const isInputEntered = await driver.keys(text);
return isInputEntered;
enterInput(text) {
return driver.keys(text);
}

async getField(field) {
Expand Down
Loading