WEBUI-1385-BACKPORT: Fix update of Template properties #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alokhyland
requested review from
MohinishSah and
poonamyadav252
and removed request for
MohinishSah and
poonamyadav252
alokhyland
changed the title
alokhyland
force-pushed
the
fix-WEBUI-1385-BACKPORT-fix-update-of-template-properties
branch
from
39f8b43 to
a9160f9
Compare
alokhyland
requested review from
swarnadipa-dev,
Nishant0928 and
madhurkulshrestha-hyland
madhurkulshrestha-hyland
requested changes
Feb 22, 2024
| @@ -191,7 +192,8 @@ Polymer({ | |||
| _documentChanged() { | |||
| if (this.document) { | |||
| this.set('document.properties.tmpl:templateType', this.document.properties['tmpl:templateType'] || 'auto'); | |||
| this.set('editedDocument', JSON.parse(JSON.stringify(this.document))); | |||
| this.set('editedDocument', this._parseJSON(this.document)); | |||
| if (this.unmodifiedDocument === undefined) this.unmodifiedDocument = this._parseJSON(this.document); | |||
There was a problem hiding this comment.
Use ternary operator for this condition
There was a problem hiding this comment.
got lint issue if used ternary operator
| @@ -175,6 +175,7 @@ Polymer({ | |||
| type: String, | |||
| value: 'view', | |||
| }, | |||
| unmodifiedDocument: Object, | |||
There was a problem hiding this comment.
Change name to originalDocument
| delete this.editedDocument.properties['dc:contributors']; | ||
| return this.$.doc.put(); | ||
| const modified = this._parseJSON(this.editedDocument.properties); | ||
| const org = this._parseJSON(this.unmodifiedDocument.properties); |
There was a problem hiding this comment.
Name should be meaningful. Change this to "orig" or "originalDocument"
alokhyland
force-pushed
the
fix-WEBUI-1385-BACKPORT-fix-update-of-template-properties
branch
2 times, most recently
from
6a4fd8f to
8e5bc04
Compare
madhurkulshrestha-hyland
previously approved these changes
Feb 23, 2024
rahuljain-dev
force-pushed
the
fix-WEBUI-1385-BACKPORT-fix-update-of-template-properties
branch
2 times, most recently
from
4c8a35c to
a9da972
Compare
Nishant0928
previously approved these changes
Feb 27, 2024
| this.set('editedDocument', this._parseJSON(this.document)); | ||
| }, | ||
|
|
||
| _findChangedValues(object1, object2) { |
There was a problem hiding this comment.
please change object1, object2 parameter names to something that is understandable in context of the code.
alokhyland
dismissed stale reviews from Nishant0928 and madhurkulshrestha-hyland
via
4153fad
alokhyland
force-pushed
the
fix-WEBUI-1385-BACKPORT-fix-update-of-template-properties
branch
2 times, most recently
from
4153fad to
ae57f55
Compare
swarnadipa-dev
previously approved these changes
Feb 27, 2024
alokhyland
force-pushed
the
fix-WEBUI-1385-BACKPORT-fix-update-of-template-properties
branch
from
ae57f55 to
95d0530
Compare
madhurkulshrestha-hyland
approved these changes
Feb 28, 2024
swarnadipa-dev
approved these changes
Feb 28, 2024
Nishant0928
approved these changes
Feb 28, 2024
alokhyland
deleted the
fix-WEBUI-1385-BACKPORT-fix-update-of-template-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.