Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXPY-261: Deploy artifacts to pypi.org #316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

poojadaine
Copy link
Contributor

@poojadaine poojadaine commented Nov 8, 2024

Summary by Sourcery

Deployment:

  • Update deployment configuration to publish artifacts to pypi.org instead of the Nuxeo repository.

Copy link
Contributor

sourcery-ai bot commented Nov 8, 2024

Reviewer's Guide by Sourcery

This PR modifies the GitHub Actions release workflow to deploy Python artifacts to pypi.org instead of the internal Nuxeo package repository. The implementation changes the authentication mechanism to use PyPI's token-based authentication.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated PyPI deployment configuration in GitHub Actions workflow
  • Removed Nuxeo package repository URL configuration
  • Switched authentication to use PyPI token-based authentication
  • Commented out previous Nuxeo-specific credentials
  • Maintained skip_existing and verbose settings
.github/workflows/release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


unknown seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @poojadaine - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please remove the commented-out repository configuration instead of leaving it in the code. If needed, the old configuration can be referenced through version control history.
  • The PR modifies CHANGELOG.rst but the changes are not visible in the diff. Please ensure the changelog is properly updated to reflect these deployment changes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants