-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXPY-261: Deploy artifacts to pypi.org #316
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR modifies the GitHub Actions release workflow to deploy Python artifacts to pypi.org instead of the internal Nuxeo package repository. The implementation changes the authentication mechanism to use PyPI's token-based authentication. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
unknown seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @poojadaine - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please remove the commented-out repository configuration instead of leaving it in the code. If needed, the old configuration can be referenced through version control history.
- The PR modifies CHANGELOG.rst but the changes are not visible in the diff. Please ensure the changelog is properly updated to reflect these deployment changes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Deployment: