Use Docker files for Linux workflows #666
Conversation
|
Awesomee, thanks, @zjeffer! |
There was a problem hiding this comment.
This is really nice work, thank you!
I have a few questions, that I should've asked in the previous PR, actually.
I'm not 100% sure how Docker works, but from I understand, ideally, these images have to be kept constantly up to date, right?
For example, in a scenario where a package in Ubuntu 20.04 (that we ship to users in the AppImage) has a serious CVE, do you have to rebuild and republish these images to the Docker website? Or, when we pull these images from our CI, the base image is automatically updated?
Based on a local test, I assume it's the first option: I pulled zjeffer/notes:ubuntu-22_04 (which was last updated two months ago), and there were 43 packages out of date.
If that's the case, can we somehow automate the updating and publishing of these images?
I understand GitHub itself also has it's own OCI Registry, correct? So, it'd be really awesome if we could integrate that here, instead of having to dump all this maintenance work on you.
Correct.
Yes, that should be possible. We should be able to automatically build these every week or so, for example.
In my experence, the GitHub container registry is extremely slow to upload/download from. That's why I always use the official Docker registry. It should still be possible to automate the builds with this, so there won't be any maintanance work from my side. |
This PR converts the rest of the linux workflows to use docker images, speeding up the CI/CD.