Skip to content

Conversation

bramwesselo
Copy link
Collaborator

minor changes

added dependencies on nl-core and eu-base

@bramwesselo bramwesselo requested a review from reinkrul October 3, 2025 10:02
Copy link
Member

@stevenvegt stevenvegt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good busy!

@bramwesselo
Copy link
Collaborator Author

On-hold: Momenteel nog in geprek met Pieter Edelman (NictiZ) om nl-core package te kunnen gebruiken.

@stevenvegt stevenvegt marked this pull request as draft October 7, 2025 07:12
@bramwesselo
Copy link
Collaborator Author

Kan w.m.b. nu gemerged worden

@bramwesselo bramwesselo marked this pull request as ready for review October 10, 2025 15:17
Copy link
Member

@stevenvegt stevenvegt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kun de urn urn:oid:2.16.840.1.113883.2.4.6.7 nog als een alias worden opgenomen?

Je verwijst op diverse plekken naar de NLCore profielen, maar die worden nergens gebruikt?

@rolandgroen
Copy link
Contributor

I see that nictiz has released 0.12.0-beta.4, i'll check if that version also has the issue.

@rolandgroen
Copy link
Contributor

From the changelog:

This beta release introduces the following changes:

ZIBFHIR-380: The dependency on FHIR in the package manifests is written as “4.0.1” instead of “4.0.x” as a workaround for a bug in the IG Publisher.
ZIBFHIR-366: Extra documentation has been added regarding the TreatmentDirective2 zib2020 R4 implementation. In addition, extra guidance has been added on the use if .provision.type`.

@bramwesselo bramwesselo linked an issue Oct 14, 2025 that may be closed by this pull request
@bramwesselo
Copy link
Collaborator Author

From the changelog:

This beta release introduces the following changes:
ZIBFHIR-380: The dependency on FHIR in the package manifests is written as “4.0.1” instead of “4.0.x” as a workaround for a bug in the IG Publisher.
ZIBFHIR-366: Extra documentation has been added regarding the TreatmentDirective2 zib2020 R4 implementation. In addition, extra guidance has been added on the use if .provision.type`.

@rolandgroen Ik heb hiervoor een ticket bij Nictiz aangemaakt (waar ik zelf niet bij kan, maar ZIBFHIR-365 werd genoemd door Pieter Edelman)

@bramwesselo
Copy link
Collaborator Author

@rolandgroen: not only the ZIB-packages had issues, but also the FHIR IG Publisher (first it would be solved in version 2.0.17, but now it is finally solved in 2.0.19....)

Copy link
Contributor

@rolandgroen rolandgroen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some (probably harmless) renaming of aliases that I not fully understand, but that seems fine.
The dependency bump is the most important part.

@bramwesselo bramwesselo merged commit c6d9ea8 into main Oct 15, 2025
@bramwesselo bramwesselo deleted the bugfix-nl-core-dependency-4.0.x branch October 15, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Base GF-Adressing profile on NL-core profiles

3 participants