Error Reporting & Exception Catching Refactor #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- More reorganization in WinNUT_Globals.vb. Renaming some variables for clarity. - Updated dependencies - Refactor error report generation. Attempts to account for more error conditions and ensure a report can be generated.
- Added in code so the unhandled exception method can be tested while debugging - Try to define invariant culture and use it at critical points so crash logs come back in English. Will make providing support easier. - Unescape newline characters in serialization output
gbakeman
changed the title
gbakeman
changed the title
gbakeman
changed the title
- General code cleanup throughout files - Refactored Disconnect subroutine in the Socket class; there is no more "silent" operation, and the SocketDisconnected event is always raised regardless of result. We will also avoid trying to log out when not already logged in. - Added a ToString function to UPS_Device to give the UPSName property. I'm realizing that depending on a valid instance of Nut_Config for any of the properties to successfully return is fairly problematic, so this may necessitate the need to migrate to Nut.Net. - Made the Disconnect subroutine in UPS_Device the final stop for handling exceptions generated during the procedure. Any communication is raised as events back to a listening client. - Removed unused Watchdog subroutine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #79 and #80:
Another issue like #49 , some thrown exceptions aren't being caught by the bug report generator. More work is needed in that area.
In addition,
certainSynology NUT servers allow a client to LOGIN successfully, but will then reply ACCESS-DENIED to a LOGOUT command. I don't think this should be happening, but regardless, we're not catching a protocol exception and allowing it to crash the program. Need to make sure we're handling protocol exceptions appropriately.Summary of changes