[Resolves #142] Add lifetimes to VAddr & PAddr#150
Draft
michalfita wants to merge 1 commit intonuta:mainfrom
Draft
[Resolves #142] Add lifetimes to VAddr & PAddr#150michalfita wants to merge 1 commit intonuta:mainfrom
michalfita wants to merge 1 commit intonuta:mainfrom
Conversation
nuta
reviewed
Feb 8, 2022
| #[derive(Debug, Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Hash)] | ||
| #[repr(transparent)] | ||
| pub struct PAddr(usize); | ||
| pub struct PAddr<'memory> { |
Owner
There was a problem hiding this comment.
Use 'a to follow a naming convention in Rust.
Suggested change
| pub struct PAddr<'memory> { | |
| pub struct PAddr<'a> { |
Contributor
Author
There was a problem hiding this comment.
@nuta there's no such convention - lifetimes should be named in meaningful way.
|
|
||
| pub struct OwnedPages { | ||
| paddr: PAddr, | ||
| pub struct OwnedPages<'memory> { |
Owner
There was a problem hiding this comment.
Ditto
Suggested change
| pub struct OwnedPages<'memory> { | |
| pub struct OwnedPages<'a> { |
Owner
I haven't tested locally but how about deleting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An unfinished attempt to add lifetimes to
VAddr&PAddr(as per #142).@nuta I stuck with:
I'm not the expert of lifetimes, but I read this a problem with the lifetime of the closure as argument of
traverse(). Any suggestions welcome.Pre-Submission Checklist
When you submit a PR, please make sure your PR satisfies the following checklist:
cargo clippywarnings.rustfmt.