Add ReedlineEvent::SubmitOrSpace #965
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves nushell/nushell#9227 without changing the default behavior.
Context
The issue reports that when tab completion is active, pressing space doesn't accept the currently selected option (unlike pressing Enter). Instead, the completion menu persists, which differs from the expected behavior in most shells.
I've been struggling with this issue myself. While it seems most users haven't encountered it, I'll leave it up to you whether to approve this change.
What this PR does
With this fix, pressing space during tab completion will accept the current selection and close the completion menu.
Example with nushell:
will update the buffer to:
similar to the behavior in zsh or fish or pwsh.