Add Vi o command to swap anchor and cursor
#877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sholderbach
reviewed
Feb 10, 2025
There was a problem hiding this comment.
I never stop learning new things about vim :) Didn't know about this Visual mode feature.
The feature part looks good to me. So the only thing that needs rework is the part extending the selection by a "character", which should now be covered by the changes in #867. Then we should be good to land.
Thanks for the tests as well!
thomasschafer
force-pushed
the
tschafer-add-command-to-swap-anchor-and-cursor
branch
from
7a5937a to
1df24d5
Compare
sholderbach
approved these changes
Feb 13, 2025
Comment on lines
+116
to
+119
| Some('o') => { | ||
| let _ = input.next(); | ||
| Some(Command::SwapCursorAndAnchor) | ||
| } |
There was a problem hiding this comment.
I think in theory this dispatch from the parser is insufficient as it would compete with the normal mode o (open insert mode in the line below) and we don't discriminate between the modes here.
But as we don't have that o implemented yet (as far as i can tell) this should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a keybinding to
oin Vi visual mode, which swaps the cursor and the anchor - see here for Vim docs explaining this behaviour.