[W6.2b][T16-2] Ang Jie Liang #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephlewyh
reviewed
Sep 30, 2018
| @@ -39,4 +39,9 @@ public CommandResult execute() { | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
Remember to update your method with header comments as your method has a different behaviour from other subclass implementations. e.g. Returns if true if class mutates data.
| @@ -85,7 +85,9 @@ public CommandResult execute(String userCommandText) throws Exception { | |||
| private CommandResult execute(Command command) throws Exception { | |||
| command.setData(addressBook, lastShownList); | |||
| CommandResult result = command.execute(); | |||
| storage.save(addressBook); | |||
| if (command.isMutating()){ | |||
There was a problem hiding this comment.
This change doesn’t help much because it does not confirm that the saving happens only for mutating commands. Tests will pass even if you don’t have this change. To be complete, you should have an else branch that confirms the file was not updated for non mutating commands (e.g. by checking the last updated time of the file).
|
Good effort, Jie Liang. Do note that you will need to update header comments for each of the implemented overridden methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.