[W6.2][F09-3]Sandhya Gopakumar #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyiii
reviewed
Sep 24, 2018
| @@ -53,7 +48,14 @@ public void setData(AddressBook addressBook, List<? extends ReadOnlyPerson> rele | |||
| this.addressBook = addressBook; | |||
| this.relevantPersons = relevantPersons; | |||
| } | |||
|
|
|||
| /**Checks if the command mutates data. | |||
There was a problem hiding this comment.
A more precise phrasing for the heade is Returns true if … (instead of Checks if …)
| */ | ||
| public static boolean isMutating(String userCommandChoice) | ||
| { | ||
| if(userCommandChoice == "add" || userCommandChoice == "delete") |
There was a problem hiding this comment.
You should make use of polymorphism for this task (having different implementations in different subclasses). There is also no need to make this a static method that takes in any arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.