[W6.2b][T16-2] Perry Wang #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephlewyh
reviewed
Sep 23, 2018
| @@ -15,6 +15,7 @@ | |||
| protected AddressBook addressBook; | |||
| protected List<? extends ReadOnlyPerson> relevantPersons; | |||
| private int targetIndex = -1; | |||
| protected boolean mutatesData; | |||
There was a problem hiding this comment.
this variable is not used anywhere in your implementation. you may wish to omit this.
| @@ -26,6 +27,10 @@ public Command(int targetIndex) { | |||
| protected Command() { | |||
| } | |||
|
|
|||
| public boolean isMutating() { | |||
There was a problem hiding this comment.
Having a default implementation for isMutating() in the parent class is good as it reduces the amount of code. However, using an arbitrary default return value (like true) would reduce code understandability - as its subclasses implementations are returning false. Instead, you could declare isMutating() as an abstract method with no method body.
| @@ -16,4 +16,8 @@ public CommandResult execute() { | |||
| return new CommandResult(MESSAGE_EXIT_ACKNOWEDGEMENT); | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean isMutating() { | |||
There was a problem hiding this comment.
Remember to update your method with header comments as your overriden method has a different behaviour from the parent class implementation. e.g. Returns if true if class mutates data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added polymorphism to Command class