Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W5.6][T16-2] Perry Wang Zhiming #191

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[W5.6][T16-2] Perry Wang Zhiming #191

wants to merge 9 commits into from

Commits on Sep 11, 2018

  1. Applied encapsulation to feedbackToUser class property: changed varia… 

    …ble access from public to private, and added a getFeedbackToUser() method.
    @perrywzm
    perrywzm committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    b7dbf84 View commit details
    Browse the repository at this point in the history

  2. All instances of accessing private property feedbackToUser of class C… 

    …ommandResult replaced with call to public getFeedbackToUser() method instead.
    @perrywzm
    perrywzm committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    5dbe3a0 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2018

  1. Added FindByTag command class to find persons who contain a specified… 

    … tag.
    @perrywzm
    perrywzm committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    227398c View commit details
    Browse the repository at this point in the history

  2. Added FindByTag command parsing to input Parser class

    @perrywzm
    perrywzm committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    8ea5653 View commit details
    Browse the repository at this point in the history

  3. Fixed javadocs for FindByTagCommand

    @perrywzm
    perrywzm committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    ffcb8f8 View commit details
    Browse the repository at this point in the history

  4. Added FindByTag listing to the HelpCommand

    @perrywzm
    perrywzm committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    71033a0 View commit details
    Browse the repository at this point in the history

  5. Fixed FindByTagCommand message usage

    @perrywzm
    perrywzm committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    6569295 View commit details
    Browse the repository at this point in the history

  6. Added JUnit and I/O test cases

    @perrywzm
    perrywzm committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    878cb26 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2018

  1. Added Contact superclass for Address, Email & Phone subclass to inherit

    @perrywzm
    perrywzm committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    d4a912d View commit details
    Browse the repository at this point in the history