[W5.11][F10-3]Shreyas Kuthanoor Prakash #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_command Added confirm/cancel clear option to after clear command
Includes Clear/Cancel command prompt guide
Update UserGuide
Add delete_name command
Trying to merge
added total command and edited user guide
[W5.11][CS2113-AY1819S1-F10-3]Ong Wee Keong
Revert "[W5.11][CS2113-AY1819S1-F10-3]Ong Wee Keong"
[W 5.11][CS2113-AY1819S1-F10-3]Ong Wee Keong
…ressbook-level2 into feature/top_five
fanyiii
reviewed
Sep 16, 2018
| */ | ||
|
|
||
| public class TopFiveCommand extends Command{ | ||
| public static final String COMMAND_WORD = "topFive"; |
There was a problem hiding this comment.
maybe to keep the command word format consistent, you can use top_five instead of camelCase, or simply top might be more intuitive and user-friendly
There was a problem hiding this comment.
alternatively, you might want to allow the user to specify how many persons to list, so command like 'top 5'
| import seedu.addressbook.commands.ListCommand; | ||
| import seedu.addressbook.commands.ViewAllCommand; | ||
| import seedu.addressbook.commands.ViewCommand; | ||
| import seedu.addressbook.commands.*; |
There was a problem hiding this comment.
they should be imported explicitly (refer to style guide)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to list the first five persons of the addressbook.