[W5.11][F10-2]Keith Tan #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s well as user guide
|
A good QoL enhancement |
|
Excellent function and neatly implemented! |
|
A function that can greatly improve users experience as it provides convenience. Good one! |
fanyiii
reviewed
Sep 15, 2018
| @@ -40,7 +40,7 @@ public static boolean isValidName(String test) { | |||
| * Retrieves a listing of every word in the name, in order. | |||
| */ | |||
| public List<String> getWordsInName() { | |||
| return Arrays.asList(fullName.split("\\s+")); | |||
| return Arrays.asList(fullName.toLowerCase().split("\\s+")); | |||
There was a problem hiding this comment.
Consider the situation where you need to retrieve the name in its original case, can you think of perhaps a better place to convert the cases?
| || | ||
| || 0 persons listed! | ||
| || 1 persons listed! |
There was a problem hiding this comment.
You can try to come up with more test cases, e.g. the keywords are in upper cases etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the Find function case insensitive, also updated user guide as well as test expected output