-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W5.11][T12-1] Ho Phi Long #167
base: master
Are you sure you want to change the base?
[W5.11][T12-1] Ho Phi Long #167
Conversation
Checks index and shows based on index
[James] Add edit command
Commented out first because the .bat file does not work with the login function
Gerald's branch
Hi @Tertium3, your pull request title is invalid. For PR sent to satisfy a learning outcome, the PR name should be in the format of For team PR, the PR name should be in the format of Please follow the above format strictly and edit your title for reprocessing. Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorting by name feature implemented. Would love to see more functionality of this feature in the future.
Some comments on coding style have been added. Please close this PR after reading them.
public SortCommand() {} | ||
public List<ReadOnlyPerson> SortList() { | ||
//Copy the unmodifiable array to a list | ||
List<ReadOnlyPerson> SortedList = new ArrayList<ReadOnlyPerson>(addressBook.getAllPersons().immutableListView()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if this line crosses the 120 characters hard limit. If yes, consider breaking it into two lines.
import java.util.ArrayList; | ||
import java.util.Collections; | ||
import java.util.List; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding comments for this class, clarifying what kind of "sorting" this class is supposed to do.
Sort by name