Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103-F13-3] Yellow Pages #200

Open
wants to merge 403 commits into
base: master
Choose a base branch
from

Conversation

darrentde
Copy link

We are Yellow Pages! This is an address book for university pages.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2022

Codecov Report

Base: 72.15% // Head: 69.03% // Decreases project coverage by -3.11% ⚠️

Coverage data is based on head (ec39470) compared to base (77a32bf).
Patch coverage: 63.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #200      +/-   ##
============================================
- Coverage     72.15%   69.03%   -3.12%     
- Complexity      399      608     +209     
============================================
  Files            70      105      +35     
  Lines          1232     2051     +819     
  Branches        125      226     +101     
============================================
+ Hits            889     1416     +527     
- Misses          311      561     +250     
- Partials         32       74      +42     
Impacted Files Coverage Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø)
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø)
...ain/java/seedu/address/logic/commands/Command.java 100.00% <ø> (ø)
...u/address/logic/commands/DeleteMeetingCommand.java 0.00% <0.00%> (ø)
...edu/address/logic/commands/ListMeetingCommand.java 0.00% <0.00%> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <ø> (ø)
...eedu/address/logic/parser/DeleteCommandParser.java 100.00% <ø> (ø)
...dress/logic/parser/DeleteMeetingCommandParser.java 0.00% <0.00%> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 92.30% <ø> (ø)
.../seedu/address/logic/parser/FindCommandParser.java 100.00% <ø> (ø)
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tinenhao and others added 29 commits October 16, 2022 19:03
Filter Meetings between dates Command

Some minor change to variable names
Implement Delete person from meeting functionality
Create unit tests in AddressBookParserTest, CreateMeetingCommandParserTest and CreateMeetingCommandTest
Implement a sort meetings list function

Why?
Allows the user to be able to sort the meetings list based on
ascending/descending as described by the user

How?
Implemented through SortMeetingsCommand and
SortMeetingsCommandParser, it utilizes the ObservableList's .sort()
function
Update DG on feature implemented
Implemented EditMeetingCommand
GenFusion122 and others added 30 commits November 6, 2022 11:29
Added some test and updated java docs
to reflect latest changes in functional code.
that pass but interfere with other tests during Codecov evaluation
that pass but interfere with other tests during Codecov evaluation
and CreateMeetingCommandParserTest
that pass but interfere with other tests during Codecov evaluation
Add tests for CreateMeetingCommand, CreateMeetingCommandParser, DeleteMeetingCommand and DeleteMeetingCommandParser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants