Skip to content

Conversation

@butson
Copy link
Contributor

@butson butson commented Apr 24, 2025

In order to support a type column being returned from engine. A TypeObject is needed instead of returning None. As None is used to verify that the type returned is in the TYPEMAP.

cursor.execute('select NULL from DUAL')

fails without this change. There are other cases where a user might explictly return NULL in place of an actual value. Say in a view such as INFORMATION_SCHEMA.COLUMNS where we don't support DOMAIN_NAME column.

The above example was added to tests/nuodb_types_test.py

@butson butson requested a review from madscientist April 24, 2025 16:28
Copy link
Contributor

@madscientist madscientist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@butson
Copy link
Contributor Author

butson commented May 21, 2025

@madscientist I assume you will merge to master when you want to include it.

@madscientist
Copy link
Contributor

OK will do.

@madscientist
Copy link
Contributor

Pushed. You can delete the branch.

@butson butson deleted the dbutson/null branch May 22, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants