Replace MSVC lazy initialization with DllMain entry point#233
Draft
Replace MSVC lazy initialization with DllMain entry point#233
Conversation
Remove MSVC-specific lazy initialization (NULL checks) from DECLARE_INTERNAL_* and DECLARE_ALL_KEYVALUE_METHODS macros, unifying them with the non-MSVC versions. Add XSS_POST_RESOLVE macro to register resolve functions during static initialization on MSVC. Add DllMain that calls all registered resolve functions on DLL_PROCESS_ATTACH. Co-authored-by: r-devulap <44766858+r-devulap@users.noreply.github.com>
Co-authored-by: r-devulap <44766858+r-devulap@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove lazy initialization of pointers in x86simdsort
Replace MSVC lazy initialization with DllMain entry point
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MSVC, all dispatch function pointers were lazily initialized via NULL checks on every call. GCC/Clang use
__attribute__((constructor))for load-time init, but MSVC had no equivalent—just runtime overhead on every invocation.Changes
DECLARE_INTERNAL_*andDECLARE_ALL_KEYVALUE_METHODSmacros — removed the MSVC-specific variants with NULL checks and forward declarations, keeping only the direct-call versions (~130 lines of duplicated macro code deleted)XSS_POST_RESOLVEmacro — on MSVC, eachDISPATCH/DISPATCH_KV_FUNCregisters its resolve function into a static array during C++ static init; no-op on other compilersDllMainonDLL_PROCESS_ATTACH— iterates registered resolve functions and calls them all at load timeCRT static initialization order within a single TU guarantees all registrations complete before
DllMainis called by_DllMainCRTStartup.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.