Skip to content

🚚 port numpy.ma.min #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

🚚 port numpy.ma.min #474

merged 1 commit into from
Apr 7, 2025

Conversation

guan404ming
Copy link
Member

@guan404ming guan404ming added numpy.ma.* port: from numpy NumPy PR's that should be ported to NumType labels Apr 7, 2025
@guan404ming guan404ming force-pushed the port-ma-min branch 2 times, most recently from 345bede to 7a08f78 Compare April 7, 2025 08:26
@guan404ming guan404ming self-assigned this Apr 7, 2025
@jorenham jorenham self-requested a review April 7, 2025 15:24
@guan404ming guan404ming force-pushed the port-ma-min branch 2 times, most recently from 8c2c251 to 8c665e4 Compare April 7, 2025 15:27
Copy link
Member

@jorenham jorenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also some "reveal" tests that could be ported over (as accept tests). But apart from that, I've got nothing to complain about 👌🏻.

@guan404ming guan404ming force-pushed the port-ma-min branch 2 times, most recently from d80837f to a11baa6 Compare April 7, 2025 17:40
Co-Authored-By: Marco Edward Gorelli <[email protected]>
Co-Authored-By: Joren Hammudoglu <[email protected]>
@jorenham jorenham merged commit 4d5f851 into numpy:main Apr 7, 2025
21 checks passed
@jorenham
Copy link
Member

jorenham commented Apr 7, 2025

Thanks, Guan-Ming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
numpy.ma.* port: from numpy NumPy PR's that should be ported to NumType
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants