MAINT: update minimum required versions and CI maintanance #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
added
the
infrastructure
bsipocz
force-pushed
the
CI_update_versions
branch
2 times, most recently
from
3628875 to
1fc42cc
Compare
bsipocz
force-pushed
the
CI_update_versions
branch
2 times, most recently
from
cbb8e22 to
58556ae
Compare
rossbar
reviewed
Dec 21, 2023
There was a problem hiding this comment.
Thanks @bsipocz for the updates.
Instead of skipping the mooreslaw building, what about merging #182 instead to get rid of the statsmodels dependency. I think the motivation for #182 was already strong, but now that statsmodels is holding pinning us so far back from development numpy I think the motivation is even stronger
It looks like we're on the same page 🚀
rossbar
reviewed
Dec 21, 2023
Keep reinstalling numpy with a separated pip command to ensure the dev version is picked up even if a downstream dependency upper limited it
bsipocz
force-pushed
the
CI_update_versions
branch
from
58556ae to
f375a5c
Compare
|
OK, so this is now rebased and should have passing jobs with the exception of the conda ones. A debug session and hopeful fix will come for those separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll also use this PR to fix #190
I'm happy to separate the PR into two, one to bump the minimum versions following SPEC0 and the other to update and fix the devdeps job