fix(metrics): vault_injector_store_data_count_success was not cleaned… #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… up when pod is deleted by the renewer
|
This metrics is created by the injector, so it can't be deleted by the renewer. Maybe instead of exposing a metrics that can't be deleted and which can lead to a huge amount of metrics in a scenario where we have a lot of pod, we could simply create a log and handle this with something like sentry / logging system. |
…theus / endpoints
|
@SoulKyu your commit message appears to be truncated. I recommend using a more detailed commit message + extended Implement a test in this scenario are possible ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… up when pod is deleted by the renewer
#23