WIP #36
Draft
WIP #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RVSDG Refactoring
Rename the variable that is bound to the outgoing edges and use the list indexing to access the elements.
As title
As title
Adds the typing signatures to the NameGenerator, adds numpydoc compatible documentation and does some refactoring on the code, mostly variable names and shortening one construct.
Cosmetic refactor transformations
add typing and refactor NameGenerator
We add some documentation, fixup the typing signature, refactor the function to use return sorted lists, modify some implementation details and add comments to the function. We return sorted lists, because we have been bitten in the past by using sets and them being unordered.
Refactor find_headers_and_entries
Add tracing to simulator tests
Formatting fixes and typos in README
Fix bugs leftover from refactoring
Added precommit configuration file
Adding documentation, slight internal refactor, change return signature to be sorted lists. Also, refactored all uses of the function to account for the change in return signature.
Refactor find_exiting_and_exits
Added region heirarchy and fixed region rendering
Fix set intialisation in region iterator
Fix python ingestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title