Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: @types/react-router-dom is not a dependency #1508

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: @types/react-router-dom is not a dependency #1508

merged 1 commit into from
Jan 16, 2025

Conversation

jherdman
Copy link
Contributor

Description

This ought to be a dev dependency

Changes include

  • breaking change: a change that is not backwards-compatible and/or changes current functionality
  • fix: a non-breaking change that solves an issue
  • feature: a non-breaking change that adds functionality
  • chore: contains no changes affecting the library, such as documentation or test updates

Feature checklist

  • Appropriate tests have been added
  • Documentation has been updated
  • Accessibility has been considered

@jherdman
fix: @types/react-router-dom is not a dependency
409fa1d 
This ought to be a dev dependency
@jherdman jherdman requested a review from haideralsh January 15, 2025 21:50
@haideralsh haideralsh merged commit bb74e03 into master Jan 16, 2025
4 checks passed
@haideralsh haideralsh deleted the move-react-router-dom-types branch January 16, 2025 19:46
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 13.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haideralsh haideralsh haideralsh approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jherdman @haideralsh