Walk back some table types #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haideralsh
approved these changes
May 9, 2024
This is causing grief with type assertions. Let's walk this back until we can adequately type the table component.
jherdman
force-pushed
the
walk-back-some-table-types
branch
from
54671bb to
760872b
Compare
|
🎉 This PR is included in version 10.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A while back I foolishly added some
unknowntypes to the Table component. This is causing a lot of grief as we are now forced to do some heavy handed type assertions.Let's walk this back until we have time to do a more thoroughly typed Table component.
Changes include
Feature checklist