Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve DatePicker types #1375

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

haideralsh
Copy link
Contributor

Description

Improves the DatePicker component types.

Changes include

  • breaking change: a change that is not backwards-compatible and/or changes current functionality
  • fix: a non-breaking change that solves an issue
  • feature: a non-breaking change that adds functionality
  • chore: contains no changes affecting the library, such as documentation or test updates

Feature checklist

  • Appropriate tests have been added
  • Documentation has been updated
  • Accessibility has been considered

@@ -148,6 +146,7 @@ const DatePicker: React.FC<DatePickerProps> = forwardRef(
<LocaleContext.Consumer>
{({ locale }) => (
<ReactDatePicker
showTimeSelect
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this prop

@haideralsh haideralsh force-pushed the improve-date-picker-types branch from 7a9046b to 20662f7 Compare March 5, 2024 22:02
@haideralsh haideralsh merged commit 6577934 into master Mar 5, 2024
5 checks passed
@haideralsh haideralsh deleted the improve-date-picker-types branch March 5, 2024 22:16
Copy link

github-actions bot commented Mar 5, 2024

🎉 This PR is included in version 10.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant