-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop import-meta-resolve
& es-main
#488
base: master
Are you sure you want to change the base?
Conversation
89eb925
to
0422bde
Compare
import-meta-resolve
& es-main
fe7aa70
to
851d17f
Compare
Makes sense. I think we need to have the local installation option available anyway. Not everyone likes the global option. |
d93e352
to
a45b0c3
Compare
Confirmed, that packages (at least esbuild, so I think this goes for all) now need to be next to nuekit. This difference could probably only be solved by using something like |
I somehow got over this, and tested only a few things, will finally take a closer look on Wednesday, after I'm done with my next exam. |
a45b0c3
to
d65f688
Compare
In conclusion, I think, you can install nuekit globally, and if you want to use node, have to install lightningcss & esbuild next to it. |
This is currently WIP. Tests probably fail on
jest
too.This will change the behavior of importing
esbuild
andlightningcss
and probably other imported modules slightly, because they now have to be installed relative to thenuekit
installation, and not in the nue project. If someone wants to have modules only for a specific project now, they'll also need thenuekit
installation in the project itself. This is just a hunch, I'd have to check that more.TODO:
es-main
import-meta-resolve