Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI sync AWS S3 #946

Merged
merged 25 commits into from
Dec 26, 2023
Merged

CLI sync AWS S3 #946

merged 25 commits into from
Dec 26, 2023

Conversation

alishakawaguchi
Copy link
Contributor

@alishakawaguchi alishakawaguchi commented Dec 21, 2023

Will add tests in follow up PR

@alishakawaguchi alishakawaguchi self-assigned this Dec 21, 2023
Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2023 6:09pm
neosync-marketing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2023 6:09pm

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 947 lines in your changes are missing coverage. Please review.

Comparison is base (335b1f7) 60.70% compared to head (b9a0217) 56.51%.
Report is 21 commits behind head on main.

Files Patch % Lines
...1alpha1/connection-data-service/connection-data.go 7.11% 647 Missing and 6 partials ⚠️
cli/internal/cmds/neosync/sync/sync.go 0.00% 241 Missing ⚠️
backend/pkg/dbschemas/mysql/mysql.go 0.00% 21 Missing ⚠️
backend/pkg/dbschemas/postgres/postgres.go 0.00% 21 Missing ⚠️
...t/v1alpha1/connection-data-service/user-account.go 30.76% 6 Missing and 3 partials ⚠️
...g/workflows/datasync/activities/benthos-builder.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
- Coverage   60.70%   56.51%   -4.19%     
==========================================
  Files          82       84       +2     
  Lines        7980     8599     +619     
==========================================
+ Hits         4844     4860      +16     
- Misses       2564     3160     +596     
- Partials      572      579       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 14 to 15
MysqlOpen(dataSourceName string) (*sql.DB, error)
PgPoolOpen(ctx context.Context, dataSourceName string) (*pgxpool.Pool, error)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to connection str

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants