Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-485: updated utils package and generate e164 phone #860

Merged
merged 11 commits into from
Dec 19, 2023

Conversation

evisdrenova
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 5:33am

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (b98da9f) 61.13% compared to head (6a49db5) 64.33%.
Report is 17 commits behind head on main.

Files Patch % Lines
...r/internal/benthos/transformers/transform_int64.go 54.00% 16 Missing and 7 partials ⚠️
...ternal/benthos/transformers/utils/integer_utils.go 81.25% 12 Missing and 6 partials ⚠️
...er/internal/benthos/transformers/generate_int64.go 69.09% 11 Missing and 6 partials ⚠️
...er/internal/benthos/transformers/generate_email.go 70.00% 6 Missing and 3 partials ⚠️
...enthos/transformers/generate_int64_phone_number.go 69.23% 5 Missing and 3 partials ⚠️
...r/internal/benthos/transformers/transform_email.go 78.57% 5 Missing and 1 partial ⚠️
...internal/benthos/transformers/utils/float_utils.go 90.16% 4 Missing and 2 partials ⚠️
...nternal/benthos/transformers/utils/string_utils.go 93.10% 4 Missing and 2 partials ⚠️
...benthos/transformers/generate_e164_phone_number.go 71.42% 2 Missing and 2 partials ⚠️
...er/internal/benthos/transformers/generate_float.go 78.94% 3 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
+ Coverage   61.13%   64.33%   +3.20%     
==========================================
  Files          80       81       +1     
  Lines        7953     7391     -562     
==========================================
- Hits         4862     4755     -107     
+ Misses       2519     2065     -454     
+ Partials      572      571       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evisdrenova evisdrenova merged commit f3cb54c into main Dec 19, 2023
17 checks passed
@evisdrenova evisdrenova deleted the update-transformers branch December 19, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant