add transformers #68
add transformers #68
Conversation
| @@ -1,7 +1,6 @@ | |||
| # `buf format -w` writes to each file, so causes tilt to loop. instead we instruct buf | |||
| # to just output the changes in diff format and apply those. | |||
| BUF_VERSION=$(cat BUF_VERSION) | |||
| SQLC_VERSION=$(cat SQLC_VERSION) | |||
| @@ -44,7 +44,8 @@ func (s *Service) GetConnectionSchema( | |||
|
|
|||
| conn, err := pgx.Connect(ctx, connectionString) | |||
| if err != nil { | |||
| return connect.NewResponse(&mgmtv1alpha1.GetConnectionSchemaResponse{}), nil | |||
| logger.Error("unable to connect") | |||
There was a problem hiding this comment.
are you intentionally not logging the error itself here?
backend/internal/dtomaps/jobs.go
Outdated
| if column.Transformer != nil { | ||
| name, err := getTransformerName(column.Transformer.Name) | ||
| if err != nil { | ||
| transformerName = "unspecified" |
There was a problem hiding this comment.
why unspecified instead of passthrough?
There was a problem hiding this comment.
hmm I thought passthrough was only if the transformer was empty. I guess my thought process was there is potentially a transformer defined or set on the CRD but not through the UI. In that case it's not really passthrough but not supported by the frontend either
| string transformer = 5 [(validate.rules).string = { | ||
| in: [ | ||
| "passthrough", | ||
| "uuidV4" |
There was a problem hiding this comment.
I see uuidV4 here but in other spots uuid_v4
curious why the difference?
There was a problem hiding this comment.
also this list seems to be different from the transformers package in k8s-operator? which also is only a subset of what is currently defined. planning to continue filling that out?
There was a problem hiding this comment.
oops yep meant to update that but forgot. I plan to continue filling it out
added operator transformers to api. starting with a small subset