Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEOS-306: updated card number transfomer #586

Merged
merged 5 commits into from
Nov 14, 2023
Merged

NEOS-306: updated card number transfomer #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0f0565
updated card number transfomer
evisdrenova Nov 14, 2023
1a81cef
updates to test
evisdrenova Nov 14, 2023
7365ba3
clean up
evisdrenova Nov 14, 2023
4c579ec
updated luhn check
evisdrenova Nov 14, 2023
e09183a
clean up
evisdrenova Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions backend/gen/go/protos/mgmt/v1alpha1/transformer.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

60 changes: 30 additions & 30 deletions backend/gen/go/protos/mgmt/v1alpha1/transformer.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions backend/protos/mgmt/v1alpha1/transformer.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ message TransformerConfig {
Zipcode zipcode_config = 19;
State state_config = 20;
FullAddress full_address_config = 21;
CreditCard credit_card_config = 22;
CardNumber card_number_config = 22;
SHA256Hash sha256hash_config = 23;
SocialSecurityNumber ssn_config = 24;
}
Expand Down Expand Up @@ -183,7 +183,7 @@ message State {}

message FullAddress {}

message CreditCard {
message CardNumber {
bool valid_luhn = 1;
}

Expand Down
8 changes: 4 additions & 4 deletions backend/services/mgmt/v1alpha1/transformers-service/transformers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const (
Zipcode Transformation = "zipcode"
State Transformation = "state"
FullAddress Transformation = "full_address"
CreditCard Transformation = "credit_card"
CardNumber Transformation = "card_number"
SHA256 Transformation = "sha256_hash"
SocialSecurityNumber Transformation = "social_security_number"
)
Expand Down Expand Up @@ -190,9 +190,9 @@ func (s *Service) GetSystemTransformers(
FullAddressConfig: &mgmtv1alpha1.FullAddress{},
},
}},
{Value: string(CreditCard), Config: &mgmtv1alpha1.TransformerConfig{
Config: &mgmtv1alpha1.TransformerConfig_CreditCardConfig{
CreditCardConfig: &mgmtv1alpha1.CreditCard{
{Value: string(CardNumber), Config: &mgmtv1alpha1.TransformerConfig{
Config: &mgmtv1alpha1.TransformerConfig_CardNumberConfig{
CardNumberConfig: &mgmtv1alpha1.CardNumber{
ValidLuhn: true,
},
},
Expand Down
Loading
Loading