Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[migration] associating api key with user record #568

Merged

Conversation

nickzelei
Copy link
Member

No description provided.

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 6:36pm

@nickzelei nickzelei changed the title associating api key with user record [migration] associating api key with user record Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #568 (85d5d1f) into main (87e1425) will decrease coverage by 9.41%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
- Coverage   49.30%   39.90%   -9.41%     
==========================================
  Files          54       28      -26     
  Lines        5279     2837    -2442     
==========================================
- Hits         2603     1132    -1471     
+ Misses       2356     1561     -795     
+ Partials      320      144     -176     
Files Coverage Δ
backend/internal/nucleusdb/users.go 70.54% <100.00%> (ø)
...services/mgmt/v1alpha1/api-key-service/api-keys.go 66.92% <100.00%> (-0.26%) ⬇️
backend/internal/nucleusdb/api-keys.go 70.00% <70.00%> (ø)

... and 27 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@nickzelei nickzelei marked this pull request as ready for review November 13, 2023 18:41
@nickzelei nickzelei merged commit 2f7ae20 into main Nov 13, 2023
11 of 12 checks passed
@nickzelei nickzelei deleted the nick/neos-279-update-auth-middleware-to-support-api-keys branch November 13, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant