Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes separate DB Migrations Container #524

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Nov 7, 2023

This PR does a few things:

  1. Removes the separate DB Migrations Container
  2. Adds a very paired down version of golang-migrate Up into the main backend mgmt binary.
  3. Updates compose and tilt environments to handle the changes listed above
  4. Adds ability for backend service to handle migrations automatically on boot.

The new command is mgmt migrate up

I've tested these changes in both the compose and tilt environments.

This moves us closer towards a more simplified setup and helps chip away at #496

Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 9:56pm

@nickzelei nickzelei force-pushed the nick/neos-296-remove-separate-db-migrations-image-into-backend-image branch from d8bacd9 to f76e3b3 Compare November 8, 2023 16:32
@nickzelei nickzelei force-pushed the nick/neos-296-remove-separate-db-migrations-image-into-backend-image branch from f76e3b3 to 9f81b25 Compare November 8, 2023 16:32
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #524 (e6bb5dd) into main (1b26c70) will decrease coverage by 11.80%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #524       +/-   ##
===========================================
- Coverage   48.64%   36.84%   -11.80%     
===========================================
  Files          51       24       -27     
  Lines        4938     2467     -2471     
===========================================
- Hits         2402      909     -1493     
+ Misses       2261     1462      -799     
+ Partials      275       96      -179     

see 27 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@nickzelei nickzelei marked this pull request as ready for review November 8, 2023 22:05
@nickzelei nickzelei changed the title adds migrate and scripts to API image Removes separate DB Migrations Container Nov 8, 2023
@nickzelei nickzelei merged commit 5bb4dd1 into main Nov 8, 2023
8 of 9 checks passed
@nickzelei nickzelei deleted the nick/neos-296-remove-separate-db-migrations-image-into-backend-image branch November 8, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants