Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1639: [MIGRATION] adds JobHook with Pre and Post Sync Timing Support to API #2982

Merged
merged 22 commits into from
Nov 25, 2024

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Nov 22, 2024

Coming PRs will implement this feature in Worker and then also expose via UI (and eventually terraform)

  • Fixes flaky mssql test start by disabling encrypted connections with the test container

@nickzelei nickzelei added the enhancement New feature or request label Nov 22, 2024
Copy link

linear bot commented Nov 22, 2024

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 5:40pm

Copy link

github-actions bot commented Nov 22, 2024

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 25, 2024, 5:39 PM

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 64.61825% with 190 lines in your changes missing coverage. Please review.

Project coverage is 35.44%. Comparing base (26bba87) to head (b762918).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
backend/internal/ee/hooks/jobs/service.go 60.37% 97 Missing and 50 partials ⚠️
backend/internal/ee/hooks/jobs/user-account.go 40.62% 13 Missing and 6 partials ⚠️
backend/internal/cmds/mgmt/serve/connect/cmd.go 0.00% 11 Missing ⚠️
backend/internal/dtomaps/job-hooks.go 76.31% 6 Missing and 3 partials ⚠️
...ackend/services/mgmt/v1alpha1/job-service/hooks.go 93.75% 2 Missing and 1 partial ⚠️
...nal/testutil/testcontainers/sqlserver/sqlserver.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2982      +/-   ##
==========================================
+ Coverage   35.01%   35.44%   +0.42%     
==========================================
  Files         330      334       +4     
  Lines       38422    38958     +536     
==========================================
+ Hits        13453    13807     +354     
- Misses      23404    23528     +124     
- Partials     1565     1623      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@nickzelei nickzelei changed the title NEOS-1639: add prepost sync sql hooks NEOS-1639: add JobHook with Pre and Post Sync Timing Support Nov 23, 2024
@nickzelei nickzelei marked this pull request as ready for review November 25, 2024 16:58
@nickzelei nickzelei changed the title NEOS-1639: add JobHook with Pre and Post Sync Timing Support NEOS-1639: [MIGRATION] add JobHook with Pre and Post Sync Timing Support Nov 25, 2024
@nickzelei nickzelei changed the title NEOS-1639: [MIGRATION] add JobHook with Pre and Post Sync Timing Support NEOS-1639: [MIGRATION] adds JobHook with Pre and Post Sync Timing Support Nov 25, 2024
@nickzelei nickzelei changed the title NEOS-1639: [MIGRATION] adds JobHook with Pre and Post Sync Timing Support NEOS-1639: [MIGRATION] adds JobHook with Pre and Post Sync Timing Support to API Nov 25, 2024
func (s *Service) GetJobHooks(
ctx context.Context,
req *connect.Request[mgmtv1alpha1.GetJobHooksRequest],
) (*connect.Response[mgmtv1alpha1.GetJobHooksResponse], error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@nickzelei nickzelei merged commit 0f405b0 into main Nov 25, 2024
21 checks passed
@nickzelei nickzelei deleted the nick/neos-1639-add-prepost-sync-sql-hooks branch November 25, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants