NEOS-1625: updates temporal schedule errors to be unique #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue per invocation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2971 +/- ##
=======================================
Coverage 35.00% 35.01%
=======================================
Files 330 330
Lines 38428 38425 -3
=======================================
+ Hits 13452 13454 +2
+ Misses 23411 23408 -3
+ Partials 1565 1563 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
alishakawaguchi
approved these changes
Nov 21, 2024
nickzelei
deleted the
nick/neos-1625-investigate-err-log-bug-in-getjobrunstatuses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously logging each error from temporal schedule with the same message. This PR updates that to be unique for better tracking.
Also when describing job statuses, we were layering in the wrong error message, that has been fixed. - It has also been updated to a warn as this error is common when job runs have been archived.