Mark all fields as readonly

docs/controller_events.rst

@@ -38,7 +38,7 @@ resetting to go to the homepage.
      */
     class PasswordResettingListener implements EventSubscriberInterface
     {
-        private $router;
+        private readonly $router;
 
         public function __construct(UrlGeneratorInterface $router)
         {

src/Action/AccountDeletionAction.php

@@ -34,17 +34,17 @@
 
 final class AccountDeletionAction
 {
-    private Environment $twig;
+    private readonly Environment $twig;
 
-    private RouterInterface $router;
+    private readonly RouterInterface $router;
 
-    private UserManager $userManager;
+    private readonly UserManager $userManager;
 
-    private TokenStorageInterface $tokenStorage;
+    private readonly TokenStorageInterface $tokenStorage;
 
-    private FormFactoryInterface $formFactory;
+    private readonly FormFactoryInterface $formFactory;
 
-    private EventDispatcherInterface $eventDispatcher;
+    private readonly EventDispatcherInterface $eventDispatcher;
 
     public function __construct(
         Environment $twig,

src/Action/CheckEmailAction.php

@@ -21,11 +21,11 @@
 
 final class CheckEmailAction
 {
-    private Environment $twig;
+    private readonly Environment $twig;
 
-    private RouterInterface $router;
+    private readonly RouterInterface $router;
 
-    private int $retryTtl;
+    private readonly int $retryTtl;
 
     public function __construct(Environment $twig, RouterInterface $router, int $retryTtl)
     {

src/Action/LoginAction.php

@@ -28,17 +28,17 @@
 
 final class LoginAction
 {
-    private Environment $twig;
+    private readonly Environment $twig;
 
-    private EventDispatcherInterface $eventDispatcher;
+    private readonly EventDispatcherInterface $eventDispatcher;
 
-    private FormFactoryInterface $formFactory;
+    private readonly FormFactoryInterface $formFactory;
 
-    private RouterInterface $router;
+    private readonly RouterInterface $router;
 
-    private CsrfTokenManagerInterface $csrfTokenManager;
+    private readonly CsrfTokenManagerInterface $csrfTokenManager;
 
-    private AuthenticationUtils $authenticationUtils;
+    private readonly AuthenticationUtils $authenticationUtils;
 
     public function __construct(
         Environment $twig,
@@ -62,27 +62,27 @@
     public function __invoke(Request $request): Response
     {
         $event = new GetResponseLoginEvent($request);
         $this->eventDispatcher->dispatch($event, NucleosUserEvents::SECURITY_LOGIN_INITIALIZE);
 
         if (null !== $event->getResponse()) {
             return $event->getResponse();
         }
 
         $form = $this->formFactory
             ->create(LoginFormType::class, null, [
                 'action' => $this->router->generate('nucleos_user_security_check'),
                 'method' => 'POST',
             ])
             ->add('save', SubmitType::class, [
                 'label' => 'security.login.submit',
             ])
         ;
 
         return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', [
             'form'          => $form->createView(),
             'last_username' => $this->authenticationUtils->getLastUsername(),
             'error'         => $this->authenticationUtils->getLastAuthenticationError(),
             'csrf_token'    => $this->csrfTokenManager->getToken('authenticate'),
         ]));
     }
 }

src/Action/RequestResetAction.php

@@ -20,11 +20,11 @@
 
 final class RequestResetAction
 {
-    private Environment $twig;
+    private readonly Environment $twig;
 
-    private FormFactoryInterface $formFactory;
+    private readonly FormFactoryInterface $formFactory;
 
-    private RouterInterface $router;
+    private readonly RouterInterface $router;
 
     public function __construct(Environment $twig, FormFactoryInterface $formFactory, RouterInterface $router)
     {
@@ -36,11 +36,11 @@
     public function __invoke(): Response
     {
         $form = $this->formFactory
             ->create(RequestPasswordFormType::class, null, [
                 'action' => $this->router->generate('nucleos_user_resetting_send_email'),
                 'method' => 'POST',
             ])
             ->add('save', SubmitType::class, [
                 'label' => 'resetting.request.submit',
             ])
         ;

src/Action/ResetAction.php

@@ -29,17 +29,17 @@
 
 final class ResetAction
 {
-    private Environment $twig;
+    private readonly Environment $twig;
 
-    private RouterInterface $router;
+    private readonly RouterInterface $router;
 
-    private EventDispatcherInterface $eventDispatcher;
+    private readonly EventDispatcherInterface $eventDispatcher;
 
-    private FormFactoryInterface $formFactory;
+    private readonly FormFactoryInterface $formFactory;
 
-    private UserManager $userManager;
+    private readonly UserManager $userManager;
 
-    private string $loggedinRoute;
+    private readonly string $loggedinRoute;
 
     public function __construct(
         Environment $twig,

src/Action/SendEmailAction.php

@@ -29,19 +29,19 @@
 
 final class SendEmailAction
 {
-    private RouterInterface $router;
+    private readonly RouterInterface $router;
 
-    private EventDispatcherInterface $eventDispatcher;
+    private readonly EventDispatcherInterface $eventDispatcher;
 
-    private UserManager $userManager;
+    private readonly UserManager $userManager;
 
-    private TokenGenerator $tokenGenerator;
+    private readonly TokenGenerator $tokenGenerator;
 
-    private ResettingMailer $mailer;
+    private readonly ResettingMailer $mailer;
 
-    private int $retryTtl;
+    private readonly int $retryTtl;
 
-    private UserProviderInterface $userProvider;
+    private readonly UserProviderInterface $userProvider;
 
     public function __construct(
         RouterInterface $router,

src/Action/UpdateSecurityAction.php

@@ -35,19 +35,19 @@
 
 final class UpdateSecurityAction
 {
-    private Environment $twig;
+    private readonly Environment $twig;
 
-    private RouterInterface $router;
+    private readonly RouterInterface $router;
 
-    private Security $security;
+    private readonly Security $security;
 
-    private EventDispatcherInterface $eventDispatcher;
+    private readonly EventDispatcherInterface $eventDispatcher;
 
-    private FormFactoryInterface $formFactory;
+    private readonly FormFactoryInterface $formFactory;
 
-    private UserManipulator $userManipulator;
+    private readonly UserManipulator $userManipulator;
 
-    private UserManager $userManager;
+    private readonly UserManager $userManager;
 
     public function __construct(
         Environment $twig,

src/Command/ActivateUserCommand.php

@@ -25,7 +25,7 @@
 {
     protected static $defaultName = 'nucleos:user:activate';
 
-    private UserManipulator $userManipulator;
+    private readonly UserManipulator $userManipulator;
 
     public function __construct(UserManipulator $userManipulator)
     {
@@ -67,7 +67,7 @@
     {
         if (!$input->getArgument('username')) {
             $question = new Question('Please choose a username:');
             $question->setValidator(static function ($username) {
                 if ('' === trim($username)) {
                     throw new RuntimeException('Username can not be empty');
                 }

src/Command/ChangePasswordCommand.php

@@ -25,7 +25,7 @@
 {
     protected static $defaultName = 'nucleos:user:change-password';
 
-    private UserManipulator $userManipulator;
+    private readonly UserManipulator $userManipulator;
 
     public function __construct(UserManipulator $userManipulator)
     {
@@ -78,7 +78,7 @@
 
         if (!$input->getArgument('username')) {
             $question = new Question('Please give the username:');
             $question->setValidator(static function ($username) {
                 if ('' === trim($username)) {
                     throw new RuntimeException('Username can not be empty');
                 }

src/Command/CreateUserCommand.php

@@ -26,7 +26,7 @@ final class CreateUserCommand extends Command
 {
     protected static $defaultName = 'nucleos:user:create';
 
-    private UserManipulator $userManipulator;
+    private readonly UserManipulator $userManipulator;
 
     public function __construct(UserManipulator $userManipulator)
     {

src/Command/DeactivateUserCommand.php

@@ -25,7 +25,7 @@ final class DeactivateUserCommand extends Command
 {
     protected static $defaultName = 'nucleos:user:deactivate';
 
-    private UserManipulator $userManipulator;
+    private readonly UserManipulator $userManipulator;
 
     public function __construct(UserManipulator $userManipulator)
     {

src/Command/RoleCommand.php

@@ -25,7 +25,7 @@
 
 abstract class RoleCommand extends Command
 {
-    private UserManipulator $userManipulator;
+    private readonly UserManipulator $userManipulator;
 
     public function __construct(UserManipulator $userManipulator)
     {

src/DependencyInjection/NucleosUserExtension.php

@@ -33,7 +33,7 @@ final class NucleosUserExtension extends Extension implements PrependExtensionIn
      * @var array<string, array<string, string>>
      */
     private static array $doctrineDrivers = [
-        'orm' => [
+        'orm'     => [
             'registry' => 'doctrine',
             'tag'      => 'doctrine.event_subscriber',
         ],
@@ -212,7 +212,7 @@ private function loadResetting(array $config, ContainerBuilder $container, FileL
         $container->setParameter('nucleos_user.resetting.from_email', $fromEmail);
 
         $this->remapParametersNamespaces($config, $container, [
-            '' => [
+            ''      => [
                 'retry_ttl' => 'nucleos_user.resetting.retry_ttl',
                 'token_ttl' => 'nucleos_user.resetting.token_ttl',
             ],

src/Doctrine/GroupManager.php

@@ -25,17 +25,17 @@
  */
 final class GroupManager extends BaseGroupManager
 {
-    private ObjectManager $objectManager;
+    private readonly ObjectManager $objectManager;
 
     /**
      * @phpstan-var class-string<GroupTemplate>
      */
-    private string $class;
+    private readonly string $class;
 
     /**
      * @phpstan-var ObjectRepository<GroupTemplate>
      */
-    private ObjectRepository $repository;
+    private readonly ObjectRepository $repository;
 
     /**
      * @phpstan-param class-string<GroupTemplate> $class

src/Doctrine/UserListener.php

@@ -26,7 +26,7 @@
 
 final class UserListener implements EventSubscriber
 {
-    private UserPasswordHasherInterface $userPasswordHasher;
+    private readonly UserPasswordHasherInterface $userPasswordHasher;
 
     public function __construct(UserPasswordHasherInterface $userPasswordHasher)
     {

src/Doctrine/UserManager.php

@@ -20,12 +20,12 @@
 
 final class UserManager extends BaseUserManager
 {
-    private ObjectManager $objectManager;
+    private readonly ObjectManager $objectManager;
 
     /**
      * @phpstan-var class-string<UserInterface>
      */
-    private string $class;
+    private readonly string $class;
 
     /**
      * @phpstan-param class-string<UserInterface> $class
@@ -44,11 +44,6 @@ public function deleteUser(UserInterface $user): void
 
     public function getClass(): string
     {
-        if (false !== strpos($this->class, ':')) {
-            $metadata    = $this->objectManager->getClassMetadata($this->class);
-            $this->class = $metadata->getName();
-        }
-
         return $this->class;
     }
 

src/Event/AccountDeletionEvent.php

@@ -19,9 +19,9 @@
 
 class AccountDeletionEvent extends Event
 {
-    private Request $request;
+    private readonly Request $request;
 
-    private UserInterface $user;
+    private readonly UserInterface $user;
 
     public function __construct(UserInterface $user, Request $request)
     {

src/Event/AccountDeletionResponseEvent.php

@@ -19,7 +19,7 @@
 
 final class AccountDeletionResponseEvent extends AccountDeletionEvent
 {
-    private Response $response;
+    private readonly Response $response;
 
     public function __construct(UserInterface $user, Request $request, Response $response)
     {

src/Event/FormEvent.php

@@ -20,9 +20,9 @@
 
 class FormEvent extends Event
 {
-    private FormInterface $form;
+    private readonly FormInterface $form;
 
-    private Request $request;
+    private readonly Request $request;
 
     private ?Response $response = null;
 

src/Event/GetResponseLoginEvent.php

@@ -17,7 +17,7 @@
 
 final class GetResponseLoginEvent extends Event
 {
-    private ?Request $request;
+    private readonly ?Request $request;
 
     private ?Response $response = null;
 

src/Event/GroupEvent.php

@@ -19,9 +19,9 @@
 
 class GroupEvent extends Event
 {
-    private GroupInterface $group;
+    private readonly GroupInterface $group;
 
-    private Request $request;
+    private readonly Request $request;
 
     public function __construct(GroupInterface $group, Request $request)
     {

src/Event/UserEvent.php

@@ -21,7 +21,7 @@ class UserEvent extends Event
 {
     protected ?Request $request = null;
 
-    protected UserInterface $user;
+    protected readonly UserInterface $user;
 
     public function __construct(UserInterface $user, Request $request = null)
     {

src/EventListener/AuthenticationListener.php

@@ -23,9 +23,9 @@
 
 final class AuthenticationListener implements EventSubscriberInterface
 {
-    private LoginManager $loginManager;
+    private readonly LoginManager $loginManager;
 
-    private string $firewallName;
+    private readonly string $firewallName;
 
     public function __construct(LoginManager $loginManager, string $firewallName)
     {

src/EventListener/FlashListener.php

@@ -34,9 +34,9 @@ final class FlashListener implements EventSubscriberInterface
         NucleosUserEvents::ACCOUNT_DELETION_SUCCESS  => 'deletion.success',
     ];
 
-    private RequestStack $requestStack;
+    private readonly RequestStack $requestStack;
 
-    private TranslatorInterface $translator;
+    private readonly TranslatorInterface $translator;
 
     public function __construct(RequestStack $requestStack, TranslatorInterface $translator)
     {

src/EventListener/LastLoginListener.php

@@ -24,7 +24,7 @@
 
 final class LastLoginListener implements EventSubscriberInterface
 {
-    private UserManager $userManager;
+    private readonly UserManager $userManager;
 
     public function __construct(UserManager $userManager)
     {

src/EventListener/LocaleEventListener.php

@@ -26,7 +26,7 @@
 
 final class LocaleEventListener implements EventSubscriberInterface
 {
-    private LocaleAwareTranslator $translator;
+    private readonly LocaleAwareTranslator $translator;
 
     public function __construct(LocaleAwareTranslator $translator)
     {