Make new password field optional on update security page #2215
core23
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
continuous-integration.yml
on: push
run
/
Generate test matrix
2s
Matrix: run / Code Coverage
Matrix: run / Coding Standards
Matrix: run / Lint composer.json
Matrix: run / Lint symfony container
Matrix: run / Mutation Tests
Matrix: run / Static Code Analysis
Matrix: run / Lint twig files
Matrix: run / Lint XLIFF files
Matrix: run / Lint YML files
Matrix: run / tests
Annotations
10 warnings
|
run / Mutation Tests (8.2):
src/Action/LoginAction.php#L65
Escaped Mutant for Mutator "MethodCallRemoval":
--- Original
+++ New
@@ @@
public function __invoke(Request $request) : Response
{
$event = new GetResponseLoginEvent($request);
- $this->eventDispatcher->dispatch($event, NucleosUserEvents::SECURITY_LOGIN_INITIALIZE);
+
if (null !== $event->getResponse()) {
return $event->getResponse();
}
|
|
run / Mutation Tests (8.2):
src/Action/LoginAction.php#L72
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
if (null !== $event->getResponse()) {
return $event->getResponse();
}
- $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
+ $form = $this->formFactory->create(LoginFormType::class, null, ['method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.2):
src/Action/LoginAction.php#L76
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
if (null !== $event->getResponse()) {
return $event->getResponse();
}
- $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
+ $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, []);
return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.2):
src/Action/LoginAction.php#L83
Escaped Mutant for Mutator "ArrayItem":
--- Original
+++ New
@@ @@
return $event->getResponse();
}
$form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
- return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
+ return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' > $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.2):
src/Action/LoginAction.php#L84
Escaped Mutant for Mutator "ArrayItem":
--- Original
+++ New
@@ @@
return $event->getResponse();
}
$form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
- return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
+ return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' > $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.2):
src/Action/LoginAction.php#L85
Escaped Mutant for Mutator "ArrayItem":
--- Original
+++ New
@@ @@
return $event->getResponse();
}
$form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
- return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
+ return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' > $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.2):
src/Action/RequestResetAction.php#L39
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
}
public function __invoke() : Response
{
- $form = $this->formFactory->create(RequestPasswordFormType::class, null, ['action' => $this->router->generate('nucleos_user_resetting_send_email'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'resetting.request.submit']);
+ $form = $this->formFactory->create(RequestPasswordFormType::class, null, ['method' => 'POST'])->add('save', SubmitType::class, ['label' => 'resetting.request.submit']);
return new Response($this->twig->render('@NucleosUser/Resetting/request.html.twig', ['form' => $form->createView()]));
}
}
|
|
run / Mutation Tests (8.2):
src/Action/RequestResetAction.php#L43
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
}
public function __invoke() : Response
{
- $form = $this->formFactory->create(RequestPasswordFormType::class, null, ['action' => $this->router->generate('nucleos_user_resetting_send_email'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'resetting.request.submit']);
+ $form = $this->formFactory->create(RequestPasswordFormType::class, null, ['action' => $this->router->generate('nucleos_user_resetting_send_email'), 'method' => 'POST'])->add('save', SubmitType::class, []);
return new Response($this->twig->render('@NucleosUser/Resetting/request.html.twig', ['form' => $form->createView()]));
}
}
|
|
run / Mutation Tests (8.2):
src/Command/ActivateUserCommand.php#L70
Escaped Mutant for Mutator "MethodCallRemoval":
--- Original
+++ New
@@ @@
{
if (!$input->getArgument('username')) {
$question = new Question('Please choose a username:');
- $question->setValidator(static function ($username) {
- if ('' === trim($username)) {
- throw new RuntimeException('Username can not be empty');
- }
- return $username;
- });
+
$answer = $this->getHelper('question')->ask($input, $output, $question);
$input->setArgument('username', $answer);
}
}
}
|
|
run / Mutation Tests (8.2):
src/Command/ChangePasswordCommand.php#L81
Escaped Mutant for Mutator "MethodCallRemoval":
--- Original
+++ New
@@ @@
$questions = [];
if (!$input->getArgument('username')) {
$question = new Question('Please give the username:');
- $question->setValidator(static function ($username) {
- if ('' === trim($username)) {
- throw new RuntimeException('Username can not be empty');
- }
- return $username;
- });
+
$questions['username'] = $question;
}
if (!$input->getArgument('password')) {
|