Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCSE-287]Cleanup Thank You Page #118

Open
wants to merge 60 commits into
base: main
Choose a base branch
from
Open

[SCSE-287]Cleanup Thank You Page #118

wants to merge 60 commits into from

Conversation

kingsmil
Copy link

No description provided.

chanbakjsd and others added 30 commits June 28, 2023 23:56
@chanbakjsd
feat: Implement orders and products endpoint
4005a5b 
[SCSE-236]
[SCSE-237]
@YoNG-Zaii @chanbakjsd
task: Port home page (product listing) (#77)
6cb831d
@chanbakjsd
feat(merch): Add CORS
a37a603
@chanbakjsd
fix: Add CORS types
5e856e0
@chanbakjsd
feat: Add pricing calculator
4a15e74
@nicolelst @chanbakjsd
feat(merch): Implement product page
36e8840
@chanbakjsd
chore: Run prettier on all merch files
7c78c06
@chanbakjsd
cleanup: Merge Cart and CartItem
cefa476
@chanbakjsd
fix: Use state.cart.items instead of state.items
85797e4
@RealDyllon @chanbakjsd
update CODEOWNERS
ce5aa0b
@RealDyllon @chanbakjsd
update CODEOWNERS
68dd27e
@YoNG-Zaii @chanbakjsd
feat(cart): Add cart button component (#95)
a43a14c
@meisterisk @chanbakjsd
Port thank you page (#99)
4f52a32
@chanbakjsd
fix: Handle 404 in orders
f9b2435
@ykcyberarts @chanbakjsd
feat: Init checkout feature (#102)
1e7765a
@chanbakjsd
cleanup: Rework merch backend
3619d57
@chanbakjsd
chore: Move swiper dependency to web
b34d137 
[SCSE-275]
@chanbakjsd
fix: Add key to grid item
a0a003d
@chanbakjsd
chore: Rename JSONResponse to Response
71ccac4
@chanbakjsd
feat: Add name and image to quotation
7029629
@YoNG-Zaii @chanbakjsd
fix: Merch top padding
5e7d1e8
@nicolelst @chanbakjsd
feat: add cart page (#96)
2182d0d 
[SCSE-271]
@chanbakjsd
cleanup: Remove quotation HTTP request
57c71a4
@RealDyllon @chanbakjsd
feat: Add merch payment
672d80a
@chanbakjsd
fix: Enable product selection by default
288e6e6
@chanbakjsd
chore: Fix yarn.lock
2926dc5
@RealDyllon
fix web build
970951b
@RealDyllon
update ci to use build:ci scripts for inter-app builds
81e53c2
@RealDyllon
fix lint
d896673
@RealDyllon
fix ci
085326a
@linear
Copy link

linear bot commented Jul 10, 2023

SCSE-287 Cleanup Thank You Page

@vercel
Copy link

vercel bot commented Jul 10, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
website-ui-storybook ✅ Ready (Inspect) Visit Preview Jul 12, 2023 1:56am

@kingsmil kingsmil changed the base branch from main to merch July 10, 2023 12:38
chanbakjsd
chanbakjsd requested changes Jul 10, 2023
View reviewed changes
Copy link
Member

@chanbakjsd chanbakjsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things that we need to address first.

packages/ui/components/merch/QRCode.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Base automatically changed from merch to main March 17, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanbakjsd chanbakjsd chanbakjsd requested changes

@xJQx xJQx Awaiting requested review from xJQx

@jamiegoh jamiegoh Awaiting requested review from jamiegoh

@RealDyllon RealDyllon Awaiting requested review from RealDyllon

@aryans1204 aryans1204 Awaiting requested review from aryans1204 aryans1204 is a code owner

@jack-thant jack-thant Awaiting requested review from jack-thant jack-thant is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@kingsmil @chanbakjsd @YoNG-Zaii @nicolelst @RealDyllon @meisterisk @ykcyberarts