-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Modernize setuptools packaging with pyproject.toml
#158
Conversation
pyproject.toml
Ignore the "1 failed deployment" -- I was testing the actions workflow for deploying to testpypi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor note, our contributing instructions talk about using -e
in install but that won't work without a setup.cfg I believe. Otherwise everything worked as expected that I tested out locally.
Thanks for the review. FWIW, I was able to run |
Summary of changes
setup.py
in favor of more modernpyproject.toml
-- we continue to use setuptools for packaging.tox -e format
(Enforce single-quoted strings)References: