Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket #16

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Websocket #16

wants to merge 15 commits into from

Conversation

Pager07
Copy link

@Pager07 Pager07 commented Aug 24, 2024

added web socket implementation...

work to be done.. making pr for other's reference..

Copy link

vercel bot commented Aug 24, 2024

@Pager07 is attempting to deploy a commit to the ntegrals' projects Team on Vercel.

A member of the Team first needs to authorize it.

@ntegrals
Copy link
Owner

@Pager07 Awesome work. Thank you so much 🙏 I'll properly review your commits soon!

@Pager07
Copy link
Author

Pager07 commented Aug 27, 2024

@integrals, I've noticed that the code in this pr could use some cleanup— it might benefit from some refactoring and structural improvements. Since I'm still getting familiar with server actions and the Vercel ecosystem, I'd really appreciate your help in this area.

@Pager07
Copy link
Author

Pager07 commented Aug 27, 2024

@integrals, I’m also considering that closing the WebSocket after handling each prompt might not be the best approach. For future improvements, we might want to keep the WebSocket connection alive throughout the entire conversation to enhance efficiency and responsiveness.

@siddicky
Copy link

siddicky commented Sep 4, 2024

In serverless environments web sockets may not be feasible and alternatives like stream-hooks with zod-stream would be better suited. Intructor.js docs cover this issue well:
https://js.useinstructor.com/concepts/streaming/#alternatives-in-serverless-environments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants