-
Notifications
You must be signed in to change notification settings - Fork 47
Add more tests for FSTree #3473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Andrey Butusov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3473 +/- ##
==========================================
+ Coverage 22.96% 22.98% +0.02%
==========================================
Files 669 669
Lines 50083 50089 +6
==========================================
+ Hits 11501 11514 +13
+ Misses 37681 37676 -5
+ Partials 901 899 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
342c6cb to
fc0f210
Compare
Make cleaner tests code, remove duplication. Signed-off-by: Andrey Butusov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the FSTree test code by extracting common functionality into a shared file and adding new comprehensive benchmarks. The main purpose is to reduce code duplication across test files and expand test coverage with additional benchmark scenarios.
Key changes include:
- Creation of a common test utilities file to consolidate shared functions
- Addition of comprehensive benchmarks for Head, Get, and GetStream operations
- Refactoring of existing benchmark tests to use the new shared utilities
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
common_test.go |
New file containing shared test utilities and helper functions |
bench_test.go |
New comprehensive benchmark suite for FSTree operations |
head_bench_test.go |
Refactored to use common utilities, removed duplicate code |
head_test.go |
Refactored to use common utilities, moved shared function to common file |
range_bench_test.go |
Refactored to use common utilities, cleaned up duplicate setup code |
Ref #3451.