Skip to content

Conversation

@End-rey
Copy link
Contributor

@End-rey End-rey commented Jul 17, 2025

Ref #3451.

@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.98%. Comparing base (334de34) to head (fc0f210).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3473      +/-   ##
==========================================
+ Coverage   22.96%   22.98%   +0.02%     
==========================================
  Files         669      669              
  Lines       50083    50089       +6     
==========================================
+ Hits        11501    11514      +13     
+ Misses      37681    37676       -5     
+ Partials      901      899       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roman-khimov roman-khimov requested a review from Copilot July 18, 2025 12:05

This comment was marked as outdated.

@End-rey End-rey force-pushed the bench-test-for-fstree branch from 342c6cb to fc0f210 Compare July 21, 2025 14:12
Make cleaner tests code, remove duplication.

Signed-off-by: Andrey Butusov <[email protected]>
@roman-khimov roman-khimov requested a review from Copilot July 21, 2025 14:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the FSTree test code by extracting common functionality into a shared file and adding new comprehensive benchmarks. The main purpose is to reduce code duplication across test files and expand test coverage with additional benchmark scenarios.

Key changes include:

  • Creation of a common test utilities file to consolidate shared functions
  • Addition of comprehensive benchmarks for Head, Get, and GetStream operations
  • Refactoring of existing benchmark tests to use the new shared utilities

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
common_test.go New file containing shared test utilities and helper functions
bench_test.go New comprehensive benchmark suite for FSTree operations
head_bench_test.go Refactored to use common utilities, removed duplicate code
head_test.go Refactored to use common utilities, moved shared function to common file
range_bench_test.go Refactored to use common utilities, cleaned up duplicate setup code

@roman-khimov roman-khimov merged commit 31d76ff into master Jul 21, 2025
22 of 23 checks passed
@roman-khimov roman-khimov deleted the bench-test-for-fstree branch July 21, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants