Drop broken deleted parameter of DatasetClient.show_dataset()

CHANGELOG.md

@@ -3,6 +3,8 @@
 * Dropped support for Python 3.7. Added support for Python 3.12. Added support
   for Galaxy releases 23.2 and 24.0.
 
+* Dropped broken ``deleted`` parameter of ``DatasetClient.show_dataset()``.
+
 * Parameters after ``password`` in the ``__init__()`` method of the
   ``GalaxyClient``, ``GalaxyInstance`` and ``ToolShedInstance`` classes are now
   keyword-only.

bioblend/_tests/TestGalaxyDatasets.py

@@ -30,7 +30,13 @@ def test_show_nonexistent_dataset(self):
             self.gi.datasets.show_dataset("nonexistent_id")
 
     def test_show_dataset(self):
-        self.gi.datasets.show_dataset(self.dataset_id)
+        dataset = self.gi.datasets.show_dataset(self.dataset_id)
+        assert dataset["id"] == self.dataset_id
+        assert not dataset["deleted"]
+        self.gi.histories.delete_dataset(self.history_id, self.dataset_id)
+        dataset = self.gi.datasets.show_dataset(self.dataset_id)
+        assert dataset["id"] == self.dataset_id
+        assert dataset["deleted"]
 
     def test_download_dataset(self):
         with pytest.raises((TypeError, ConnectionError)):

bioblend/galaxy/datasets/__init__.py

@@ -42,16 +42,13 @@ class DatasetClient(Client):
     def __init__(self, galaxy_instance: "GalaxyInstance") -> None:
         super().__init__(galaxy_instance)
 
-    def show_dataset(self, dataset_id: str, deleted: bool = False, hda_ldda: HdaLdda = "hda") -> Dict[str, Any]:
+    def show_dataset(self, dataset_id: str, hda_ldda: HdaLdda = "hda") -> Dict[str, Any]:
         """
         Get details about a given dataset. This can be a history or a library dataset.
 
         :type dataset_id: str
         :param dataset_id: Encoded dataset ID
 
-        :type deleted: bool
-        :param deleted: Whether to return results for a deleted dataset
-
         :type hda_ldda: str
         :param hda_ldda: Whether to show a history dataset ('hda' - the default) or library
                          dataset ('ldda').
@@ -62,7 +59,7 @@ def show_dataset(self, dataset_id: str, deleted: bool = False, hda_ldda: HdaLdda
         params = dict(
             hda_ldda=hda_ldda,
         )
-        return self._get(id=dataset_id, deleted=deleted, params=params)
+        return self._get(id=dataset_id, params=params)
 
     def _initiate_download(
         self, dataset_id: str, stream_content: bool, require_ok_state: bool = True, maxwait: float = 12000