Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds OAStackViewProxy to support native UIStackView in iOS 9 #32

Closed
wants to merge 1 commit into from

Conversation

natanrolnik
Copy link

For now, it only supports it in code

@natanrolnik
Copy link
Author

As mentioned in #2 - I preferred to do the UIView approach.

All properties needed to be declared and the setters pass the property to the correct stack view (native or backwards compatible).
The methods declared in the interface didn't need to be implemented, as the class implements methodSignatureForSelector: and forwardInvocation.

@natanrolnik
Copy link
Author

And bear in mind it doesn't support interface builder yet.

@nsomar
Copy link
Owner

nsomar commented Aug 8, 2015

That is a nice approach, Thanks!
Do you think you can add a simple test (preferably on a new spec file)?

@natanrolnik
Copy link
Author

Hey Omar! I'll try to add it soon.

@nsomar
Copy link
Owner

nsomar commented Aug 9, 2015

Please also don't forget to rebase since I fixed the test failing issue in iOS7. Again wonderful addition, I think we can expand on it to have a seamless iOS 9 integration :)

@nsomar
Copy link
Owner

nsomar commented Aug 13, 2015

Hey, Any updates on this, I can add the tests and rebase in the weekend if you want.

@natanrolnik
Copy link
Author

Hey Omar! I tried to rebase a few days ago, but had some problems (did you change the file tree?). If you could do it, that would be awesome.

@nsomar
Copy link
Owner

nsomar commented Aug 13, 2015

Sure I will do that no problem!
Yeah, Sadly I added some files, and moved some code around. Anyways, I will rebase and add some tests.
I will create a pull request with the tests so that you can give me your opinion on wether they cover all your planned scenarios. I will share them in a new branch prior to merge.
Does that sound good to you?

Thanks for the great addition btw!

@k06a
Copy link

k06a commented Jan 21, 2016

@natanrolnik maybe you'll suggest me how to use native NSLayoutAnchor API category if API is available? https://github.com/k06a/MissingAnchors/blob/master/Pod/Classes/ABLayoutAnchor/UIView%2BABLayoutAnchor.m

@natanrolnik
Copy link
Author

Hm, interesting... I will try to take a look.

@joemasilotti joemasilotti mentioned this pull request May 4, 2016
@natanrolnik
Copy link
Author

Closing as #87 was merged already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants