Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Did the necessary docstring cleanup as discussed in #590 #596

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

Sherwin-14
Copy link
Contributor

@Sherwin-14 Sherwin-14 commented Jun 11, 2024

I've done the changes as discussed. Please have a look at it ;). Closes #590


📚 Documentation preview 📚: https://earthaccess--596.org.readthedocs.build/en/596/

@Sherwin-14 Sherwin-14 force-pushed the docleanup branch 2 times, most recently from 09a515a to 294230e Compare June 11, 2024 11:14
earthaccess/auth.py Outdated Show resolved Hide resolved
earthaccess/daac.py Outdated Show resolved Hide resolved
Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above for the suggestions, I forgot to start a review and just added comments :)

Created an issue to track the need to deal with the placeholder text: #597

earthaccess/auth.py Show resolved Hide resolved
earthaccess/store.py Outdated Show resolved Hide resolved
Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Looks great!

@mfisher87 mfisher87 dismissed chuckwondo’s stale review June 12, 2024 00:03

Change request addressed by PR author

@mfisher87 mfisher87 merged commit 57c55d9 into nsidc:main Jun 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some docstring cleanup
3 participants