Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly revert 205e6c7: set title if a title is provided, otherwise use ylabel as title.
IMO, the title should convey the main meaning of the chart. If you just want to compare performance of different kernels in a single chart it makes sense to move the only relevant information from the ylabel to the title. If you want to compare performance for different scenarios, however, i.e. if there's another parameter besides the one on the x axis, it's necessary to put this additional parameter in the title of the chart and hence leave the ylabel at the axis, see for instance here. Of course you can fix it after the plot as in lines 57-58 here but it would be much easier to have to possibility to call
perfplot
with the desired parameters.If you don't supply a title nothing changes as compared to the current behavior, so it's fully backwards compatible. If you provide a title it'll be set as the axes title and the default title will become the y label.
I didn't understand how you run your pytests - for me (my default backend is
Qt5Agg
) they open plot windows that have to be closed manually for the tests to carry on, so I wasn't able to run them automatically. In the two tests I added I used my usual approach for this, not sure if you like it (here I described an alternative).