Add support for the v1beta1 alerts api. #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add api class. - Add tests. - Add examples.
apantelopoulosNS1
approved these changes
Oct 29, 2024
|
|
||
| class Alerts(resource.BaseResource): | ||
| ROOT = "../alerting/v1beta1/alerts" | ||
| PASSTHRU_FIELDS = [ |
There was a problem hiding this comment.
what about type/subtype?
There was a problem hiding this comment.
Those aren't passthru as they are required on create, so can be named params in that call, and are immutable afterwards so aren't specified later.
| ) | ||
| ], | ||
| ) | ||
| def test_rest_alert_create( |
There was a problem hiding this comment.
cant we add some data as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the alerts api.