Add support for the v1beta1 alerts api. #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pburrows-ns1
reviewed
Nov 6, 2024
examples/alert.tf
Outdated
| zone_names = [ns1_zone.alert_example_one.zone, ns1_zone.alert_example_two.zone] | ||
| } | ||
|
|
||
| # Nofitication list |
- Add new resource types for alerts. - Add testcases. - Add examples.
- Update version.
hhellyer
force-pushed
the
PENG-5496/add_alerts_api_support
branch
from
51dd019 to
84df954
Compare
jfarrell-NS1
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds supports for the v1beta1 alerts api.
This PR will need updating once ns1/ns1-go#244 is merged there.